chore: implement phase 1 - #2779
Draft
Tofel wants to merge 1 commit into
Draft
Conversation
📊 API Diff Results
|
Tofel
force-pushed
the
dx-5122-alerts-assertion-p1
branch
from
September 1, 2026 11:25
b406d5a to
d4124cb
Compare
Tofel
commented
Sep 1, 2026
| } | ||
|
|
||
| var forStr string | ||
| if err := opt(m, "for", &forStr); err != nil { |
Contributor
Author
There was a problem hiding this comment.
it is optional, because if for is missing it means it is equal to 0 in Grafana, which means that alert fires immediately.
Tofel
force-pushed
the
dx-5122-alerts-assertion-p1
branch
from
September 2, 2026 09:45
d4124cb to
96000d4
Compare
Strict parsers for the state and ruler endpoints (H1), a Prometheus-style duration parser, and fixtures sliced from real Grafana 13.1.0 payloads covering every required/optional-field and must-error case, including the "Normal (NoData)"/"Normal (Error)" composite reason states found live in the current fleet capture (not in the original plan's vocabulary).
Tofel
force-pushed
the
dx-5122-alerts-assertion-p1
branch
from
September 4, 2026 15:03
96000d4 to
730e632
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strict parsers for the Alertmanager state (H1) and ruler endpoints, a Prometheus-style duration parser, and fixtures sliced from live Grafana 13.1.0 payloads covering required, optional, and must-error cases — including the "Normal (NoData)"/"Normal (Error)" composite reason states seen in production (not in the original plan).
Review focus:
parse_state.go,parse_ruler.go(strictness/error cases), andduration.go.